Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6eb4e2b4 authored by Dan Carpenter's avatar Dan Carpenter Committed by Paul Moore
Browse files

SELinux: fix error code in policydb_init() 



If hashtab_create() returns a NULL pointer then we should return -ENOMEM
but instead the current code returns success.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarSerge Hallyn <serge.hallyn@canonical.com>
Acked-by: default avatarStephen Smalley <sds@tycho.nsa.gov>
Signed-off-by: default avatarPaul Moore <pmoore@redhat.com>
parent d5f3a5f6

security/selinux/ss/policydb.c

+6 −2
Original line number Diff line number Diff line
@@ -289,12 +289,16 @@ static int policydb_init(struct policydb *p) 
		goto out;



	p->filename_trans = hashtab_create(filenametr_hash, filenametr_cmp, (1 << 10));

	if (!p->filename_trans)

	if (!p->filename_trans) {

		rc = -ENOMEM;

		goto out;

	}



	p->range_tr = hashtab_create(rangetr_hash, rangetr_cmp, 256);

	if (!p->range_tr)

	if (!p->range_tr) {

		rc = -ENOMEM;

		goto out;

	}



	ebitmap_init(&p->filename_trans_ttypes);

	ebitmap_init(&p->policycaps);