Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e6ceaed authored by Sebastian Siewior's avatar Sebastian Siewior Committed by David S. Miller
Browse files

net/cpsw: optimize the for_each_slave_macro() 



text    data     bss     dec     hex filename
15530      92       4   15626    3d0a cpsw.o.before
15478      92       4   15574    3cd6 cpsw.o.after

52 bytes smaller, 13 for each invocation.

Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: default avatarMugunthan V N <mugunthanvnm@ti.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d1bd9acf

drivers/net/ethernet/ti/cpsw.c

+6 −3
Original line number Diff line number Diff line
@@ -355,12 +355,15 @@ struct cpsw_priv { 
#define napi_to_priv(napi)	container_of(napi, struct cpsw_priv, napi)

#define for_each_slave(priv, func, arg...)				\

	do {								\

		int idx;						\

		struct cpsw_slave *slave;				\

		int n;							\

		if (priv->data.dual_emac)				\

			(func)((priv)->slaves + priv->emac_port, ##arg);\

		else							\

			for (idx = 0; idx < (priv)->data.slaves; idx++)	\

				(func)((priv)->slaves + idx, ##arg);	\

			for (n = (priv)->data.slaves,			\

					slave = (priv)->slaves;		\

					n; n--)				\

				(func)(slave++, ##arg);			\

	} while (0)

#define cpsw_get_slave_ndev(priv, __slave_no__)				\

	(priv->slaves[__slave_no__].ndev)