Commit 6d5b5975 authored Nov 30, 2011 by Nicholas Bellinger

target: Remove legacy device status check from transport_execute_tasks



This patch removes a legacy se_dev_check_online() check from within
transport_execute_tasks() that should no longer be necessary as
transport_lookup_cmd_lun() is already making this call.

Using transport_cmd_check_stop() from transport_execute_tasks() should
already be checking per se_cmd context for each descriptor upon active
I/O shutdown, so no need to acquire dev->dev_status_lock again while
executing se_task submission.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Roland Dreier <roland@purestorage.com>
Cc: Joern Engel <joern@logfs.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent beb55a0c

drivers/target/target_core_transport.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -2062,13 +2062,6 @@ static int transport_execute_tasks(struct se_cmd *cmd)
		{
		int add_tasks;
		struct se_device *se_dev = cmd->se_dev;

		if (se_dev_check_online(cmd->se_dev) != 0) {
		cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
		transport_generic_request_failure(cmd);
		return 0;
		}

		/*
		* Call transport_cmd_check_stop() to see if a fabric exception
		* has occurred that prevents execution.