Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d456111 authored by Eric W. Biederman's avatar Eric W. Biederman
Browse files

sysctl: Drop & in front of every proc_handler. 



For consistency drop & in front of every proc_handler.  Explicity
taking the address is unnecessary and it prevents optimizations
like stubbing the proc_handlers to NULL.

Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
parent 86926d00

arch/arm/kernel/isa.c

+3 −3
Original line number Diff line number Diff line
@@ -26,19 +26,19 @@ static ctl_table ctl_isa_vars[4] = { 
		.data		= &isa_membase, 

		.maxlen		= sizeof(isa_membase),

		.mode		= 0444,

		.proc_handler	= &proc_dointvec,

		.proc_handler	= proc_dointvec,

	}, {

		.procname	= "portbase",

		.data		= &isa_portbase, 

		.maxlen		= sizeof(isa_portbase),

		.mode		= 0444,

		.proc_handler	= &proc_dointvec,

		.proc_handler	= proc_dointvec,

	}, {

		.procname	= "portshift",

		.data		= &isa_portshift, 

		.maxlen		= sizeof(isa_portshift),

		.mode		= 0444,

		.proc_handler	= &proc_dointvec,

		.proc_handler	= proc_dointvec,

	}, {}

};

arch/arm/mach-bcmring/arch.c

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ static struct ctl_table bcmring_sysctl_warm_reboot[] = { 
	 .data = &bcmring_arch_warm_reboot,

	 .maxlen = sizeof(int),

	 .mode = 0644,

	 .proc_handler = &proc_dointvec},

	 .proc_handler = proc_dointvec},

	{}

};

arch/frv/kernel/pm.c

+4 −4
Original line number Diff line number Diff line
@@ -303,28 +303,28 @@ static struct ctl_table pm_table[] = 
		.data		= NULL,

		.maxlen		= 0,

		.mode		= 0200,

		.proc_handler	= &sysctl_pm_do_suspend,

		.proc_handler	= sysctl_pm_do_suspend,

	},

	{

		.procname	= "cmode",

		.data		= &clock_cmode_current,

		.maxlen		= sizeof(int),

		.mode		= 0644,

		.proc_handler	= &cmode_procctl,

		.proc_handler	= cmode_procctl,

	},

	{

		.procname	= "p0",

		.data		= &clock_p0_current,

		.maxlen		= sizeof(int),

		.mode		= 0644,

		.proc_handler	= &p0_procctl,

		.proc_handler	= p0_procctl,

	},

	{

		.procname	= "cm",

		.data		= &clock_cm_current,

		.maxlen		= sizeof(int),

		.mode		= 0644,

		.proc_handler	= &cm_procctl,

		.proc_handler	= cm_procctl,

	},

	{ }

};

arch/frv/kernel/sysctl.c

+2 −2
Original line number Diff line number Diff line
@@ -180,7 +180,7 @@ static struct ctl_table frv_table[] = 
		.data		= NULL,

		.maxlen		= 0,

		.mode		= 0644,

		.proc_handler	= &procctl_frv_cachemode,

		.proc_handler	= procctl_frv_cachemode,

	},

#ifdef CONFIG_MMU

	{
@@ -188,7 +188,7 @@ static struct ctl_table frv_table[] = 
		.data		= NULL,

		.maxlen		= 0,

		.mode		= 0644,

		.proc_handler	= &procctl_frv_pin_cxnr

		.proc_handler	= procctl_frv_pin_cxnr

	},

#endif

	{}

arch/ia64/kernel/crash.c

+2 −2
Original line number Diff line number Diff line
@@ -243,14 +243,14 @@ static ctl_table kdump_ctl_table[] = { 
		.data = &kdump_on_init,

		.maxlen = sizeof(int),

		.mode = 0644,

		.proc_handler = &proc_dointvec,

		.proc_handler = proc_dointvec,

	},

	{

		.procname = "kdump_on_fatal_mca",

		.data = &kdump_on_fatal_mca,

		.maxlen = sizeof(int),

		.mode = 0644,

		.proc_handler = &proc_dointvec,

		.proc_handler = proc_dointvec,

	},

	{ }

};