Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d44698d authored by Chuck Lever's avatar Chuck Lever Committed by Anna Schumaker
Browse files

xprtrdma: Warn when there are orphaned IB objects 



WARN during transport destruction if ib_dealloc_pd() fails. This is
a sign that xprtrdma orphaned one or more RDMA API objects at some
point, which can pin lower layer kernel modules and cause shutdown
to hang.

Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Reviewed-by: default avatarSteve Wise <swise@opengridcomputing.com>
Reviewed-by: default avatarSagi Grimberg <sagig@mellanox.com>
Reviewed-by: default avatarDevesh Sharma <devesh.sharma@avagotech.com>
Tested-By: default avatarDevesh Sharma <devesh.sharma@avagotech.com>
Reviewed-by: default avatarDoug Ledford <dledford@redhat.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent d4a4f75c

net/sunrpc/xprtrdma/verbs.c

+5 −5
Original line number Diff line number Diff line
@@ -702,17 +702,17 @@ rpcrdma_ia_close(struct rpcrdma_ia *ia) 
		dprintk("RPC:       %s: ib_dereg_mr returned %i\n",

			__func__, rc);

	}



	if (ia->ri_id != NULL && !IS_ERR(ia->ri_id)) {

		if (ia->ri_id->qp)

			rdma_destroy_qp(ia->ri_id);

		rdma_destroy_id(ia->ri_id);

		ia->ri_id = NULL;

	}

	if (ia->ri_pd != NULL && !IS_ERR(ia->ri_pd)) {

		rc = ib_dealloc_pd(ia->ri_pd);

		dprintk("RPC:       %s: ib_dealloc_pd returned %i\n",

			__func__, rc);

	}



	/* If the pd is still busy, xprtrdma missed freeing a resource */

	if (ia->ri_pd && !IS_ERR(ia->ri_pd))

		WARN_ON(ib_dealloc_pd(ia->ri_pd));

}



/*