Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6ce31263 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

dma-fence: Don't BUG_ON when not absolutely needed 



It makes debugging a massive pain.

Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Gustavo Padovan <gustavo@padovan.org>
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
Reviewed-by: default avatarLucas Stach <l.stach@pengutronix.de>
Acked-by: default avatarSumit Semwal <sumit.semwal@linaro.org>
Acked-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20170720125107.26693-1-daniel.vetter@ffwll.ch


Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 4bf99144

drivers/dma-buf/dma-fence.c

+2 −2
Original line number Diff line number Diff line
@@ -48,7 +48,7 @@ static atomic64_t dma_fence_context_counter = ATOMIC64_INIT(0); 
 */

u64 dma_fence_context_alloc(unsigned num)

{

	BUG_ON(!num);

	WARN_ON(!num);

	return atomic64_add_return(num, &dma_fence_context_counter) - num;

}

EXPORT_SYMBOL(dma_fence_context_alloc);
@@ -177,7 +177,7 @@ void dma_fence_release(struct kref *kref) 


	trace_dma_fence_destroy(fence);



	BUG_ON(!list_empty(&fence->cb_list));

	WARN_ON(!list_empty(&fence->cb_list));



	if (fence->ops->release)

		fence->ops->release(fence);

include/linux/dma-fence.h

+2 −2
Original line number Diff line number Diff line
@@ -429,8 +429,8 @@ int dma_fence_get_status(struct dma_fence *fence); 
static inline void dma_fence_set_error(struct dma_fence *fence,

				       int error)

{

	BUG_ON(test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags));

	BUG_ON(error >= 0 || error < -MAX_ERRNO);

	WARN_ON(test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags));

	WARN_ON(error >= 0 || error < -MAX_ERRNO);



	fence->error = error;

}