Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6cdcb5e7 authored by Paulo Zanoni's avatar Paulo Zanoni Committed by Daniel Vetter
Browse files

drm/i915: invert the verbosity of intel_enable_fbc 



We currently print a DRM_DEBUG_KMS message on the happy path and don't
print anything on the "failed to allocate" path. On some desktop
environments (e.g., Unity) I see the "scheduling delayed FBC enable"
thousands and thousands of times on my dmesg.

So kill the useless message for the happy case, saving a lot of dmesg
space, and properly signal the "kzalloc fail" case.

Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: default avatarZoltan Nyul <zoltan.nyul@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent baf27f9b

drivers/gpu/drm/i915/intel_pm.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -381,6 +381,7 @@ void intel_enable_fbc(struct drm_crtc *crtc, unsigned long interval) 




	work = kzalloc(sizeof *work, GFP_KERNEL);

	work = kzalloc(sizeof *work, GFP_KERNEL);

	if (work == NULL) {

	if (work == NULL) {

		DRM_ERROR("Failed to allocate FBC work structure\n");

		dev_priv->display.enable_fbc(crtc, interval);

		dev_priv->display.enable_fbc(crtc, interval);

		return;

		return;

	}

	}
@@ -392,8 +393,6 @@ void intel_enable_fbc(struct drm_crtc *crtc, unsigned long interval) 




	dev_priv->fbc_work = work;

	dev_priv->fbc_work = work;





	DRM_DEBUG_KMS("scheduling delayed FBC enable\n");



	/* Delay the actual enabling to let pageflipping cease and the

	/* Delay the actual enabling to let pageflipping cease and the

	 * display to settle before starting the compression. Note that

	 * display to settle before starting the compression. Note that

	 * this delay also serves a second purpose: it allows for a

	 * this delay also serves a second purpose: it allows for a