Commit 6cd208cb authored Dec 19, 2018 by Colin Ian King Committed by Greg Kroah-Hartman Jan 09, 2019

staging: wilc1000: fix missing read_write setting when reading data



commit c58eef061dda7d843dcc0ad6fea7e597d4c377c0 upstream.

Currently the cmd.read_write setting is not initialized so it contains
garbage from the stack.  Fix this by setting it to 0 to indicate a
read is required.

Detected by CoverityScan, CID#1357925 ("Uninitialized scalar variable")

Fixes: c5c77ba1 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: stable <stable@vger.kernel.org>
Acked-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 80562cf3

drivers/staging/wilc1000/wilc_sdio.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -831,6 +831,7 @@ static int sdio_read_int(struct wilc wilc, u32 int_status)
		if (!g_sdio.irq_gpio) {
		int i;

		cmd.read_write = 0;
		cmd.function = 1;
		cmd.address = 0x04;
		cmd.data = 0;