Commit 6cc0c259 authored Feb 28, 2017 by Colin Ian King Committed by Greg Kroah-Hartman Mar 06, 2017

staging: wilc1000: add check for kmalloc allocation failure.

Add a sanity check that wid.val has been allocated, fixes a null
pointer deference on stamac when calling ether_add_copy.

Detected by CoverityScan, CID#1369537 ("Dereference null return value")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2af5f669

drivers/staging/wilc1000/host_interface.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1928,6 +1928,8 @@ static s32 Handle_Get_InActiveTime(struct wilc_vif *vif,
		wid.type = WID_STR;
		wid.size = ETH_ALEN;
		wid.val = kmalloc(wid.size, GFP_KERNEL);
		if (!wid.val)
		return -ENOMEM;

		stamac = wid.val;
		ether_addr_copy(stamac, strHostIfStaInactiveT->mac);