Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6cb6d98a authored by Colin Ian King's avatar Colin Ian King Committed by Jiri Kosina
Browse files

HID: hid-logitech: remove redundant assignment to pointer value 



The pointer value is being assigned a value and this is never read, and later
on it is being assigned a new value.  This the first assignment is redundant
and can be removed and hence also the variables report and report_list.  Cleans
up the clang warning: Value stored to 'value' during its initialization is
never read

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 47af1cdb

drivers/hid/hid-lg4ff.c

+1 −3
Original line number Diff line number Diff line
@@ -474,9 +474,7 @@ static int lg4ff_play(struct input_dev *dev, void *data, struct ff_effect *effec 
static void lg4ff_set_autocenter_default(struct input_dev *dev, u16 magnitude)

{

	struct hid_device *hid = input_get_drvdata(dev);

	struct list_head *report_list = &hid->report_enum[HID_OUTPUT_REPORT].report_list;

	struct hid_report *report = list_entry(report_list->next, struct hid_report, list);

	s32 *value = report->field[0]->value;

	s32 *value;

	u32 expand_a, expand_b;

	struct lg4ff_device_entry *entry;

	struct lg_drv_data *drv_data;