Commit 6cb49978 authored Aug 02, 2019 by Douglas Anderson Committed by Greg Kroah-Hartman Aug 29, 2019

drm/rockchip: Suspend DP late



[ Upstream commit f7ccbed656f78212593ca965d9a8f34bf24e0aab ]

In commit fe64ba5c ("drm/rockchip: Resume DP early") we moved
resume to be early but left suspend at its normal time.  This seems
like it could be OK, but casues problems if a suspend gets interrupted
partway through.  The OS only balances matching suspend/resume levels.
...so if suspend was called then resume will be called.  If suspend
late was called then resume early will be called.  ...but if suspend
was called resume early might not get called.  This leads to an
unbalance in the clock enables / disables.

Lets take the simple fix and just move suspend to be late to match.
This makes the PM core take proper care in keeping things balanced.

Fixes: fe64ba5c ("drm/rockchip: Resume DP early")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190802184616.44822-1-dianders@chromium.org


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 1c6ca092

drivers/gpu/drm/rockchip/analogix_dp-rockchip.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -436,7 +436,7 @@ static int rockchip_dp_resume(struct device *dev)

		static const struct dev_pm_ops rockchip_dp_pm_ops = {
		#ifdef CONFIG_PM_SLEEP
		.suspend = rockchip_dp_suspend,
		.suspend_late = rockchip_dp_suspend,
		.resume_early = rockchip_dp_resume,
		#endif
		};