Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6cb1269b authored by Dave Kleikamp's avatar Dave Kleikamp
Browse files

JFS: Fix sparse warnings, including endian error 



The fix in inode.c is a real bug.  It could result in undeleted, yet
unconnected files on big-endian hardware.

The others are trivial.

Signed-off-by: default avatarDave Kleikamp <shaggy@austin.ibm.com>
parent f3591fff

fs/jfs/inode.c

+1 −2
Original line number Diff line number Diff line
@@ -129,8 +129,7 @@ void jfs_delete_inode(struct inode *inode) 
	jfs_info("In jfs_delete_inode, inode = 0x%p", inode);



	if (!is_bad_inode(inode) &&

	    (JFS_IP(inode)->fileset == cpu_to_le32(FILESYSTEM_I))) {



	    (JFS_IP(inode)->fileset == FILESYSTEM_I)) {

		truncate_inode_pages(&inode->i_data, 0);



		if (test_cflag(COMMIT_Freewmap, inode))

fs/jfs/jfs_dmap.c

+1 −1
Original line number Diff line number Diff line
@@ -3055,7 +3055,7 @@ static int cntlz(u32 value) 
 * RETURN VALUES:

 *      log2 number of blocks

 */

int blkstol2(s64 nb)

static int blkstol2(s64 nb)

{

	int l2nb;

	s64 mask;		/* meant to be signed */

fs/jfs/jfs_txnmgr.c

+3 −3
Original line number Diff line number Diff line
@@ -2070,7 +2070,7 @@ static void xtLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd, 
 *

 * function:    log from maplock of freed data extents;

 */

void mapLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,

static void mapLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,

		   struct tlock * tlck)

{

	struct pxd_lock *pxdlock;
@@ -2209,7 +2209,7 @@ void txEA(tid_t tid, struct inode *ip, dxd_t * oldea, dxd_t * newea) 
 * function: synchronously write pages locked by transaction

 *              after txLog() but before txUpdateMap();

 */

void txForce(struct tblock * tblk)

static void txForce(struct tblock * tblk)

{

	struct tlock *tlck;

	lid_t lid, next;