Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c943a05 authored by Amit Shekhar's avatar Amit Shekhar Committed by Gerrit - the friendly Code Review server
Browse files

msm: vidc: Reject read only OPB buffer in split mode 



Requirement stipulates OPB to be writable buffer in split mode.
Erring out in case of read only buffer will help debugging quickly.

Change-Id: I529a97b3d0aa5f82e7cf7d024475338a9d24d1dd
Signed-off-by: default avatarAmit Shekhar <ashekhar@codeaurora.org>
parent 4fc4b562

msm/vidc/msm_vidc_common.c

+7 −0
Original line number Diff line number Diff line
@@ -2567,6 +2567,13 @@ static void handle_fbd(enum hal_command_response cmd, void *data) 
	mbuf->flags &= ~MSM_VIDC_FLAG_QUEUED;

	vb = &mbuf->vvb.vb2_buf;



	if (fill_buf_done->buffer_type == HAL_BUFFER_OUTPUT2 &&

		fill_buf_done->flags1 & HAL_BUFFERFLAG_READONLY) {

		dprintk(VIDC_ERR,

			"%s: Read only buffer not allowed for OPB\n", __func__);

		goto exit;

	}



	if (fill_buf_done->flags1 & HAL_BUFFERFLAG_DROP_FRAME)

		fill_buf_done->filled_len1 = 0;

	vb->planes[0].bytesused = fill_buf_done->filled_len1;