Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c62c98f authored by Chris Wilson's avatar Chris Wilson Committed by Daniel Vetter
Browse files

drm/mediatek: Remove redundant calls to drm_connector_register_all() 



Up to now, the recommendation was for drivers to call drm_dev_register()
followed by drm_connector_register_all(). Now that
drm_connector_register() is safe against multiple invocations, we can
move drm_connector_register_all() to drm_dev_register() and not suffer
from any backwards compatibility issues with drivers not following the
more rigorous init ordering.

Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-mediatek@lists.infradead.org
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1466151923-1572-6-git-send-email-chris@chris-wilson.co.uk
parent 1e7c3e30

drivers/gpu/drm/mediatek/mtk_drm_drv.c

+0 −7
Original line number Diff line number Diff line
@@ -293,14 +293,8 @@ static int mtk_drm_bind(struct device *dev) 
	if (ret < 0)

		goto err_deinit;



	ret = drm_connector_register_all(drm);

	if (ret < 0)

		goto err_unregister;



	return 0;



err_unregister:

	drm_dev_unregister(drm);

err_deinit:

	mtk_drm_kms_deinit(drm);

err_free:
@@ -455,7 +449,6 @@ static int mtk_drm_remove(struct platform_device *pdev) 
	struct drm_device *drm = private->drm;

	int i;



	drm_connector_unregister_all(drm);

	drm_dev_unregister(drm);

	mtk_drm_kms_deinit(drm);

	drm_dev_unref(drm);