Commit 6c2075f7 authored Oct 03, 2018 by Garry McNulty Committed by Greg Kroah-Hartman Dec 01, 2019

fs/cifs: fix uninitialised variable warnings



[ Upstream commit ef2298a06d012973bbc592b86fe5ff730d4d0c63 ]

In some error conditions, resp_buftype can be passed uninitialised to
free_rsp_buf(), potentially resulting in a spurious debug message.
If resp_buftype randomly had the value 1 (CIFS_SMALL_BUFFER) then this
would log a debug message.
The rsp pointer is initialised to NULL so there is no other side-effect.

Detected by CoverityScan, CID 1438585 ("Uninitialized scalar variable")
Detected by CoverityScan, CID 1438667 ("Uninitialized scalar variable")
Detected by CoverityScan, CID 1438764 ("Uninitialized scalar variable")

Signed-off-by: Garry McNulty <garrmcnu@gmail.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent c5621fbd

fs/cifs/smb2pdu.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -2283,7 +2283,7 @@ SMB2_open(const unsigned int xid, struct cifs_open_parms oparms, __le16 path,
		struct cifs_ses *ses = tcon->ses;
		struct kvec iov[SMB2_CREATE_IOV_SIZE];
		struct kvec rsp_iov = {NULL, 0};
		int resp_buftype;
		int resp_buftype = CIFS_NO_BUFFER;
		int rc = 0;
		int flags = 0;

		@@ -2570,7 +2570,7 @@ SMB2_close_flags(const unsigned int xid, struct cifs_tcon *tcon,
		struct cifs_ses *ses = tcon->ses;
		struct kvec iov[1];
		struct kvec rsp_iov;
		int resp_buftype;
		int resp_buftype = CIFS_NO_BUFFER;
		int rc = 0;

		cifs_dbg(FYI, "Close\n");
		@@ -2723,7 +2723,7 @@ query_info(const unsigned int xid, struct cifs_tcon *tcon,
		struct kvec iov[1];
		struct kvec rsp_iov;
		int rc = 0;
		int resp_buftype;
		int resp_buftype = CIFS_NO_BUFFER;
		struct cifs_ses *ses = tcon->ses;
		int flags = 0;