Commit 6be72b90 authored Jun 28, 2017 by Angelo Compagnucci Committed by Jonathan Cameron Jul 02, 2017

iio: adc: mcp3422: Checking for error on probe



Some part of the configuration are not touched after the probe
and if something goes wrong on writing the initial one,
the chip will misbehave.
Adding an error checking ensures that the inital configuration will
be written correctly. Moreover ensures that a sensible configuration
will be saved in driver data and used subsequently as intended.

Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Reported-by: Maarten Brock <m.brock@vanmierlo.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

parent e3169994

drivers/iio/adc/mcp3422.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -382,7 +382,9 @@ static int mcp3422_probe(struct i2c_client *client,
		\| MCP3422_CHANNEL_VALUE(0)
		\| MCP3422_PGA_VALUE(MCP3422_PGA_1)
		\| MCP3422_SAMPLE_RATE_VALUE(MCP3422_SRATE_240));
		mcp3422_update_config(adc, config);
		err = mcp3422_update_config(adc, config);
		if (err < 0)
		return err;

		err = devm_iio_device_register(&client->dev, indio_dev);
		if (err < 0)