Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b3fc149 authored by Trond Myklebust's avatar Trond Myklebust Committed by Greg Kroah-Hartman
Browse files

NFSv4: Don't hold the layoutget locks across multiple RPC calls 



[ Upstream commit 6949493884fe88500de4af182588e071cf1544ee ]

When doing layoutget as part of the open() compound, we have to be
careful to release the layout locks before we can call any further RPC
calls, such as setattr(). The reason is that those calls could trigger
a recall, which could deadlock.

Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent c4bf25d2

fs/nfs/nfs4proc.c

+4 −0
Original line number Diff line number Diff line
@@ -2920,6 +2920,10 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata, 
	}



out:

	if (opendata->lgp) {

		nfs4_lgopen_release(opendata->lgp);

		opendata->lgp = NULL;

	}

	if (!opendata->cancelled)

		nfs4_sequence_free_slot(&opendata->o_res.seq_res);

	return ret;