Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6b1dce25 authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

[media] cx25821: s_input didn't check for invalid input 



The s_input implementation allowed input 1 even if that didn't exist.

Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent a8f35ce3

drivers/media/pci/cx25821/cx25821-video.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -1163,10 +1163,8 @@ int cx25821_vidioc_s_input(struct file *file, void *priv, unsigned int i) 
			return err;

			return err;

	}

	}





	if (i >= CX25821_NR_INPUT) {

	if (i >= CX25821_NR_INPUT || INPUT(i)->type == 0)

		dprintk(1, "%s(): -EINVAL\n", __func__);

		return -EINVAL;

		return -EINVAL;

	}





	mutex_lock(&dev->lock);

	mutex_lock(&dev->lock);

	cx25821_video_mux(dev, i);

	cx25821_video_mux(dev, i);