Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6aa256b6 authored by Daniel Mack's avatar Daniel Mack Committed by Mark Brown
Browse files

ASoC: fsl: use strncpy() to prevent copying of over-long names 



Use strncpy() instead of strcpy(). That's not a security issue, as the
source buffer is taken from DT nodes, but we should still enforce bound
checks. Spotted by Coverity.

Signed-off-by: default avatarDaniel Mack <daniel@zonque.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f114040e

sound/soc/fsl/fsl_asrc.c

+1 −1
Original line number Diff line number Diff line
@@ -792,7 +792,7 @@ static int fsl_asrc_probe(struct platform_device *pdev) 
		return -ENOMEM;



	asrc_priv->pdev = pdev;

	strcpy(asrc_priv->name, np->name);

	strncpy(asrc_priv->name, np->name, sizeof(asrc_priv->name) - 1);



	/* Get the addresses and IRQ */

	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

sound/soc/fsl/fsl_esai.c

+1 −1
Original line number Diff line number Diff line
@@ -734,7 +734,7 @@ static int fsl_esai_probe(struct platform_device *pdev) 
		return -ENOMEM;



	esai_priv->pdev = pdev;

	strcpy(esai_priv->name, np->name);

	strncpy(esai_priv->name, np->name, sizeof(esai_priv->name) - 1);



	/* Get the addresses and IRQ */

	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);