Commit 69eba10e authored Nov 27, 2014 by Dan Carpenter Committed by Takashi Iwai Nov 27, 2014

ALSA: hda - using uninitialized data



In olden times the snd_hda_param_read() function always set "*start_id"
but in 2007 we introduced a new return and it causes uninitialized data
bugs in a couple of the callers: print_codec_info() and
hdmi_parse_codec().

Fixes: e8a7f136 ('[ALSA] hda-intel - Improve HD-audio codec probing robustness')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 51e6f47d

sound/pci/hda/hda_codec.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -346,8 +346,10 @@ int snd_hda_get_sub_nodes(struct hda_codec *codec, hda_nid_t nid,
		unsigned int parm;

		parm = snd_hda_param_read(codec, nid, AC_PAR_NODE_COUNT);
		if (parm == -1)
		if (parm == -1) {
		*start_id = 0;
		return 0;
		}
		*start_id = (parm >> 16) & 0x7fff;
		return (int)(parm & 0x7fff);
		}