Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6987dc8a authored by Adam Borowski's avatar Adam Borowski Committed by Greg Kroah-Hartman
Browse files

vt: fix unchecked __put_user() in tioclinux ioctls 



Only read access is checked before this call.

Actually, at the moment this is not an issue, as every in-tree arch does
the same manual checks for VERIFY_READ vs VERIFY_WRITE, relying on the MMU
to tell them apart, but this wasn't the case in the past and may happen
again on some odd arch in the future.

If anyone cares about 3.7 and earlier, this is a security hole (untested)
on real 80386 CPUs.

Signed-off-by: default avatarAdam Borowski <kilobyte@angband.pl>
CC: stable@vger.kernel.org # v3.7-
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cc1e66f9

drivers/tty/vt/vt.c

+3 −3
Original line number Diff line number Diff line
@@ -2709,13 +2709,13 @@ int tioclinux(struct tty_struct *tty, unsigned long arg) 
	 * related to the kernel should not use this.

	 */

			data = vt_get_shift_state();

			ret = __put_user(data, p);

			ret = put_user(data, p);

			break;

		case TIOCL_GETMOUSEREPORTING:

			console_lock();	/* May be overkill */

			data = mouse_reporting();

			console_unlock();

			ret = __put_user(data, p);

			ret = put_user(data, p);

			break;

		case TIOCL_SETVESABLANK:

			console_lock();
@@ -2724,7 +2724,7 @@ int tioclinux(struct tty_struct *tty, unsigned long arg) 
			break;

		case TIOCL_GETKMSGREDIRECT:

			data = vt_get_kmsg_redirect();

			ret = __put_user(data, p);

			ret = put_user(data, p);

			break;

		case TIOCL_SETKMSGREDIRECT:

			if (!capable(CAP_SYS_ADMIN)) {