Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 69304cc9 authored by Ajit Khaparde's avatar Ajit Khaparde Committed by David S. Miller
Browse files

be2net: Fix a bug in Rx buffer posting 



The numPosted field in the ERX Doorbell register is 8-bits wide.
So the max buffers that we can post at a time is 255 and not 256
which we are doing currently.

Signed-off-by: default avatarAjit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5eeb2922

drivers/net/ethernet/emulex/benet/be.h

+1 −0
Original line number Diff line number Diff line
@@ -97,6 +97,7 @@ 
#define BE_NAPI_WEIGHT		64

#define MAX_RX_POST		BE_NAPI_WEIGHT /* Frags posted at a time */

#define RX_FRAGS_REFILL_WM	(RX_Q_LEN - MAX_RX_POST)

#define MAX_NUM_POST_ERX_DB	255u



#define MAX_VFS			30 /* Max VFs supported by BE3 FW */

#define FW_VER_LEN		32

drivers/net/ethernet/emulex/benet/be_main.c

+1 −1
Original line number Diff line number Diff line
@@ -2032,7 +2032,7 @@ static void be_post_rx_frags(struct be_rx_obj *rxo, gfp_t gfp, u32 frags_needed) 
		if (rxo->rx_post_starved)

			rxo->rx_post_starved = false;

		do {

			notify = min(256u, posted);

			notify = min(MAX_NUM_POST_ERX_DB, posted);

			be_rxq_notify(adapter, rxq->id, notify);

			posted -= notify;

		} while (posted);