Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 68fae2f3 authored by Marc Dietrich's avatar Marc Dietrich Committed by Greg Kroah-Hartman
Browse files

staging: nvec: remove managed resource from PS2 driver 



This basicly reverts commit e534f3e9 (staging:nvec: Introduce the use of
the managed version of kzalloc). Serio struct should never by managed
because it is refcounted. Doing so will lead to a double free oops on module
remove.

Signed-off-by: default avatarMarc Dietrich <marvin24@gmx.de>
Fixes: e534f3e9 ("staging:nvec: Introduce the use of the managed version of kzalloc")
Cc: stable <stable@vger.kernel.org> # 3.15+
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 17c1c9ba

drivers/staging/nvec/nvec_ps2.c

+1 −1
Original line number Diff line number Diff line
@@ -107,7 +107,7 @@ static int nvec_mouse_probe(struct platform_device *pdev) 
	struct nvec_chip *nvec = dev_get_drvdata(pdev->dev.parent);

	struct serio *ser_dev;



	ser_dev = devm_kzalloc(&pdev->dev, sizeof(struct serio), GFP_KERNEL);

	ser_dev = kzalloc(sizeof(struct serio), GFP_KERNEL);

	if (!ser_dev)

		return -ENOMEM;