Commit 68c9274d authored Nov 20, 2012 by Sachin Kamat Committed by MyungJoo Ham Nov 21, 2012

extcon: max8997: Fix incorrect error check and return value



irq_create_mapping() returns 0 if it fails to provide a valid irq number.
'ret' needs to be updated with a negative error code before returning from
probe to signal probe failure. While at it, also corrected the 'virq' type to
unsigned from signed.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Myungjoo Ham <myungjoo.ham@samsung.com>

parent c0c078c3

drivers/extcon/extcon-max8997.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -450,11 +450,13 @@ static int __devinit max8997_muic_probe(struct platform_device *pdev)

		for (i = 0; i < ARRAY_SIZE(muic_irqs); i++) {
		struct max8997_muic_irq *muic_irq = &muic_irqs[i];
		int virq = 0;
		unsigned int virq = 0;

		virq = irq_create_mapping(max8997->irq_domain, muic_irq->irq);
		if (!virq)
		if (!virq) {
		ret = -EINVAL;
		goto err_irq;
		}
		muic_irq->virq = virq;

		ret = request_threaded_irq(virq, NULL,max8997_muic_irq_handler,