Commit 688a48b0 authored May 23, 2017 by Viresh Kumar Committed by Rafael J. Wysocki Jun 22, 2017

PM / OPP: opp-microvolt is not optional if regulators are set



If dev_pm_opp_set_regulators() is called for a device and its regulators
are set in the OPP core, the OPP nodes for the device must contain the
"opp-microvolt" property, otherwise there is something wrong and we
better error out.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 478256bd

drivers/base/power/opp/of.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -131,8 +131,14 @@ static int opp_parse_supplies(struct dev_pm_opp opp, struct device dev,
		prop = of_find_property(opp->np, name, NULL);

		/* Missing property isn't a problem, but an invalid entry is */
		if (!prop)
		if (!prop) {
		if (!opp_table->regulator_count)
		return 0;

		dev_err(dev, "%s: opp-microvolt missing although OPP managing regulators\n",
		__func__);
		return -EINVAL;
		}
		}

		vcount = of_property_count_u32_elems(opp->np, name);