Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 67ddd757 authored by Markus Elfring's avatar Markus Elfring Committed by Sebastian Reichel
Browse files

HSI: core: Use kcalloc() in two functions 



Multiplications for the size determination of memory allocations
indicated that array data structures should be processed.
Thus use the corresponding function "kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
parent de7c98eb

drivers/hsi/hsi_core.c

+3 −4
Original line number Diff line number Diff line
@@ -267,14 +267,13 @@ static void hsi_add_client_from_dt(struct hsi_port *port, 


	cl->rx_cfg.num_channels = cells;

	cl->tx_cfg.num_channels = cells;



	cl->rx_cfg.channels = kzalloc(cells * sizeof(channel), GFP_KERNEL);

	cl->rx_cfg.channels = kcalloc(cells, sizeof(channel), GFP_KERNEL);

	if (!cl->rx_cfg.channels) {

		err = -ENOMEM;

		goto err;

	}



	cl->tx_cfg.channels = kzalloc(cells * sizeof(channel), GFP_KERNEL);

	cl->tx_cfg.channels = kcalloc(cells, sizeof(channel), GFP_KERNEL);

	if (!cl->tx_cfg.channels) {

		err = -ENOMEM;

		goto err2;
@@ -485,7 +484,7 @@ struct hsi_controller *hsi_alloc_controller(unsigned int n_ports, gfp_t flags) 
	hsi = kzalloc(sizeof(*hsi), flags);

	if (!hsi)

		return NULL;

	port = kzalloc(sizeof(*port)*n_ports, flags);

	port = kcalloc(n_ports, sizeof(*port), flags);

	if (!port) {

		kfree(hsi);

		return NULL;