Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 671abe2b authored by Andrew Davis's avatar Andrew Davis Committed by Greg Kroah-Hartman
Browse files

soc: ti: wkup_m3_ipc: Send NULL dummy message instead of pointer message 



[ Upstream commit ddbf3204f600a4d1f153498f618369fca352ae00 ]

mbox_send_message() sends a u32 bit message, not a pointer to a message.
We only convert to a pointer type as a generic type. If we want to send
a dummy message of 0, then simply send 0 (NULL).

Signed-off-by: default avatarAndrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20240325165507.30323-1-afd@ti.com


Signed-off-by: default avatarNishanth Menon <nm@ti.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 1925c902

drivers/soc/ti/wkup_m3_ipc.c

+2 −5
Original line number Diff line number Diff line
@@ -22,7 +22,6 @@ 
#include <linux/irq.h>

#include <linux/module.h>

#include <linux/of.h>

#include <linux/omap-mailbox.h>

#include <linux/platform_device.h>

#include <linux/remoteproc.h>

#include <linux/suspend.h>
@@ -158,7 +157,6 @@ static irqreturn_t wkup_m3_txev_handler(int irq, void *ipc_data) 
static int wkup_m3_ping(struct wkup_m3_ipc *m3_ipc)

{

	struct device *dev = m3_ipc->dev;

	mbox_msg_t dummy_msg = 0;

	int ret;



	if (!m3_ipc->mbox) {
@@ -174,7 +172,7 @@ static int wkup_m3_ping(struct wkup_m3_ipc *m3_ipc) 
	 * the RX callback to avoid multiple interrupts being received

	 * by the CM3.

	 */

	ret = mbox_send_message(m3_ipc->mbox, &dummy_msg);

	ret = mbox_send_message(m3_ipc->mbox, NULL);

	if (ret < 0) {

		dev_err(dev, "%s: mbox_send_message() failed: %d\n",

			__func__, ret);
@@ -196,7 +194,6 @@ static int wkup_m3_ping(struct wkup_m3_ipc *m3_ipc) 
static int wkup_m3_ping_noirq(struct wkup_m3_ipc *m3_ipc)

{

	struct device *dev = m3_ipc->dev;

	mbox_msg_t dummy_msg = 0;

	int ret;



	if (!m3_ipc->mbox) {
@@ -205,7 +202,7 @@ static int wkup_m3_ping_noirq(struct wkup_m3_ipc *m3_ipc) 
		return -EIO;

	}



	ret = mbox_send_message(m3_ipc->mbox, &dummy_msg);

	ret = mbox_send_message(m3_ipc->mbox, NULL);

	if (ret < 0) {

		dev_err(dev, "%s: mbox_send_message() failed: %d\n",

			__func__, ret);