Commit 6712cc9c authored Aug 20, 2018 by Stephen Hemminger Committed by Greg Kroah-Hartman Sep 12, 2018

vmbus: don't return values for uninitalized channels



For unsupported device types, the vmbus channel ringbuffer is never
initialized, and therefore reading the sysfs files will return garbage
or cause a kernel OOPS.

Fixes: c2e5df61 ("vmbus: add per-channel sysfs info")

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Cc: <stable@vger.kernel.org> # 4.15
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 029d727b

drivers/hv/vmbus_drv.c

+3 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1291,6 +1291,9 @@ static ssize_t vmbus_chan_attr_show(struct kobject *kobj,
	if (!attribute->show)		if (!attribute->show)
	return -EIO;		return -EIO;

			if (chan->state != CHANNEL_OPENED_STATE)
			return -EINVAL;

	return attribute->show(chan, buf);		return attribute->show(chan, buf);
	}		}