Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 66f308ed authored by Yisheng Xie's avatar Yisheng Xie Committed by Linus Torvalds
Browse files

mm/mempolicy: remove redundant check in get_nodes 

We have already checked whether maxnode is a page worth of bits, by:
    maxnode > PAGE_SIZE*BITS_PER_BYTE

So no need to check it once more.

Link: http://lkml.kernel.org/r/1510882624-44342-2-git-send-email-xieyisheng1@huawei.com


Signed-off-by: default avatarYisheng Xie <xieyisheng1@huawei.com>
Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
Acked-by: default avatarDavid Rientjes <rientjes@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Chris Salls <salls@cs.ucsb.edu>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Christopher Lameter <cl@linux.com>
Cc: Tan Xiaojun <tanxiaojun@huawei.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 2e3ca40f

mm/mempolicy.c

+0 −2
Original line number Diff line number Diff line
@@ -1282,8 +1282,6 @@ static int get_nodes(nodemask_t *nodes, const unsigned long __user *nmask, 
	/* When the user specified more nodes than supported just check

	   if the non supported part is all zero. */

	if (nlongs > BITS_TO_LONGS(MAX_NUMNODES)) {

		if (nlongs > PAGE_SIZE/sizeof(long))

			return -EINVAL;

		for (k = BITS_TO_LONGS(MAX_NUMNODES); k < nlongs; k++) {

			unsigned long t;

			if (get_user(t, nmask + k))