Commit 66414e80 authored Aug 07, 2018 by Tal Shorer Committed by Christoph Hellwig Aug 08, 2018

nvme-fabrics: fix ctrl_loss_tmo < 0 to reconnect forever

When the user supplies a ctrl_loss_tmo < 0, we warn them that this will
cause the fabrics layer to attempt reconnection forever. However, in
reality the fabrics layer never attempts to reconnect because the
condition to test whether we should reconnect is backwards in this case.

Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent dedf0be5

drivers/nvme/host/fabrics.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -474,7 +474,7 @@ EXPORT_SYMBOL_GPL(nvmf_connect_io_queue);

	bool nvmf_should_reconnect(struct nvme_ctrl *ctrl)		bool nvmf_should_reconnect(struct nvme_ctrl *ctrl)
	{		{
	if (ctrl->opts->max_reconnects != -1 &&		if (ctrl->opts->max_reconnects == -1 \|\|
	ctrl->nr_reconnects < ctrl->opts->max_reconnects)		ctrl->nr_reconnects < ctrl->opts->max_reconnects)
	return true;		return true;