Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 660e309d authored by Thomas Falcon's avatar Thomas Falcon Committed by David S. Miller
Browse files

ibmvnic: Clean actual number of RX or TX pools 



Avoid using value stored in the login response buffer when
cleaning TX and RX buffer pools since these could be inconsistent
depending on the device state. Instead use the field in the driver's
private data that tracks the number of active pools.

Signed-off-by: default avatarThomas Falcon <tlfalcon@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 906cce04

drivers/net/ethernet/ibm/ibmvnic.c

+2 −2
Original line number Diff line number Diff line
@@ -1128,7 +1128,7 @@ static void clean_rx_pools(struct ibmvnic_adapter *adapter) 
	if (!adapter->rx_pool)

		return;



	rx_scrqs = be32_to_cpu(adapter->login_rsp_buf->num_rxadd_subcrqs);

	rx_scrqs = adapter->num_active_rx_pools;

	rx_entries = adapter->req_rx_add_entries_per_subcrq;



	/* Free any remaining skbs in the rx buffer pools */
@@ -1177,7 +1177,7 @@ static void clean_tx_pools(struct ibmvnic_adapter *adapter) 
	if (!adapter->tx_pool || !adapter->tso_pool)

		return;



	tx_scrqs = be32_to_cpu(adapter->login_rsp_buf->num_txsubm_subcrqs);

	tx_scrqs = adapter->num_active_tx_pools;



	/* Free any remaining skbs in the tx buffer pools */

	for (i = 0; i < tx_scrqs; i++) {