Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6571fb3f authored by Hannes Reinecke's avatar Hannes Reinecke Committed by James Bottomley
Browse files

advansys: Update to version 3.5 and remove compilation warning 



The driver has now been converted to DMA-API, so we should
increase the version number and remove the compilation
warning.

Signed-off-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarJames Bottomley <JBottomley@Odin.com>
parent bc31ec4d

MAINTAINERS

+1 −0
Original line number Diff line number Diff line
@@ -445,6 +445,7 @@ F: drivers/input/misc/adxl34x.c 


ADVANSYS SCSI DRIVER

M:	Matthew Wilcox <matthew@wil.cx>

M:	Hannes Reinecke <hare@suse.de>

L:	linux-scsi@vger.kernel.org

S:	Maintained

F:	Documentation/scsi/advansys.txt

drivers/scsi/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -503,7 +503,7 @@ config SCSI_DPT_I2O 


config SCSI_ADVANSYS

	tristate "AdvanSys SCSI support"

	depends on SCSI && VIRT_TO_BUS

	depends on SCSI

	depends on ISA || EISA || PCI

	help

	  This is a driver for all SCSI host adapters manufactured by

drivers/scsi/advansys.c

+7 −20
Original line number Diff line number Diff line 
#define DRV_NAME "advansys"

#define ASC_VERSION "3.4"	/* AdvanSys Driver Version */



/*

 * advansys.c - Linux Host Driver for AdvanSys SCSI Adapters

 *

 * Copyright (c) 1995-2000 Advanced System Products, Inc.

 * Copyright (c) 2000-2001 ConnectCom Solutions, Inc.

 * Copyright (c) 2007 Matthew Wilcox <matthew@wil.cx>

 * Copyright (c) 2014 Hannes Reinecke <hare@suse.de>

 * All Rights Reserved.

 *

 * This program is free software; you can redistribute it and/or modify
@@ -49,26 +47,15 @@ 
#include <scsi/scsi.h>

#include <scsi/scsi_host.h>



#define DRV_NAME "advansys"

#define ASC_VERSION "3.5"	/* AdvanSys Driver Version */



/* FIXME:

 *

 *  1. Although all of the necessary command mapping places have the

 *     appropriate dma_map.. APIs, the driver still processes its internal

 *     queue using bus_to_virt() and virt_to_bus() which are illegal under

 *     the API.  The entire queue processing structure will need to be

 *     altered to fix this.

 *  2. Need to add memory mapping workaround. Test the memory mapping.

 *     If it doesn't work revert to I/O port access. Can a test be done

 *     safely?

 *  3. Handle an interrupt not working. Keep an interrupt counter in

 *     the interrupt handler. In the timeout function if the interrupt

 *     has not occurred then print a message and run in polled mode.

 *  4. Need to add support for target mode commands, cf. CAM XPT.

 *  5. check DMA mapping functions for failure

 *  6. Use scsi_transport_spi

 *  7. advansys_info is not safe against multiple simultaneous callers

 *  8. Add module_param to override ISA/VLB ioport array

 */

#warning this driver is still not properly converted to the DMA API

 *  1. Use scsi_transport_spi

 *  2. advansys_info is not safe against multiple simultaneous callers

 *  3. Add module_param to override ISA/VLB ioport array

 */



/* Enable driver /proc statistics. */

#define ADVANSYS_STATS