Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 656cb6d0 authored by Anna-Maria Gleixner's avatar Anna-Maria Gleixner Committed by Jens Axboe
Browse files

block: Remove redundant WARN_ON() 



Commit 2fff8a92 ("block: Check locking assumptions at runtime") added a
lockdep_assert_held(q->queue_lock) which makes the WARN_ON() redundant
because lockdep will detect and warn about context violations.

The unconditional WARN_ON() does not provide real additional value, so it
can be removed.

Signed-off-by: default avatarAnna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent f3a1075e

block/blk-core.c

+0 −1
Original line number Diff line number Diff line
@@ -360,7 +360,6 @@ EXPORT_SYMBOL(blk_start_queue_async); 
void blk_start_queue(struct request_queue *q)

{

	lockdep_assert_held(q->queue_lock);

	WARN_ON(!in_interrupt() && !irqs_disabled());

	WARN_ON_ONCE(q->mq_ops);



	queue_flag_clear(QUEUE_FLAG_STOPPED, q);