Commit 656bde57 authored Mar 25, 2006 by Jesper Juhl Committed by Linus Torvalds Mar 25, 2006

[PATCH] Fix memory leak in isapnp



Spotted by the Coverity checker as bug #666

akpm; there are several other `return 1;'s in there which aren't freeing
`dev'.  (A fix which converts this function to single-exit would be
preferred..)

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Adam Belay <ambx1@neo.rr.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent bda44e1d

drivers/pnp/isapnp/core.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -646,8 +646,10 @@ static int __init isapnp_create_device(struct pnp_card *card,
		size = 0;
		skip = 0;
		option = pnp_register_independent_option(dev);
		if (!option)
		if (!option) {
		kfree(dev);
		return 1;
		}
		pnp_add_card_device(card,dev);
		} else {
		skip = 1;