Commit 64e1dcbb authored Dec 27, 2017 by Alan Brady Committed by Jeff Kirsher Jan 26, 2018

i40e: fix FW_LLDP flag on init

Using ethtool --set-priv-flags disable-fw-lldp <on/off> is persistent
across reboots/reloads so we need some mechanism in the driver to detect
if it's on or off on init so we can set the ethtool private flag
appropriately. Without this, every time the driver is reloaded the flag
will default to off regardless of whether it's on or off in FW.

We detect this by first attempting to program DCB and if AQ fails
returning I40E_AQ_RC_EPERM, we know that LLDP is disabled in FW.

Signed-off-by: Alan Brady <alan.brady@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent c61c8fe1

drivers/net/ethernet/intel/i40e/i40e_main.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -6351,6 +6351,9 @@ static int i40e_init_pf_dcb(struct i40e_pf *pf)
		dev_dbg(&pf->pdev->dev,
		"DCBX offload is supported for this PF.\n");
		}
		} else if (pf->hw.aq.asq_last_status == I40E_AQ_RC_EPERM) {
		dev_info(&pf->pdev->dev, "FW LLDP disabled for this PF.\n");
		pf->flags \|= I40E_FLAG_DISABLE_FW_LLDP;
		} else {
		dev_info(&pf->pdev->dev,
		"Query for DCB configuration failed, err %s aq_err %s\n",