Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 64cd405a authored by Ivan Safonov's avatar Ivan Safonov Committed by Greg Kroah-Hartman
Browse files

staging:r8188eu: eleminate recovery attemp using skb_clone after netdev_alloc_skb fail 



It is wrong to create new skb using skb_clone instead netdev_alloc_skb,
because buffer data will be changed later.

Signed-off-by: default avatarIvan Safonov <insafonov@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 80c96e08

drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c

+3 −16
Original line number Diff line number Diff line
@@ -133,23 +133,10 @@ static int recvbuf2recvframe(struct adapter *adapt, struct sk_buff *pskb) 
			precvframe->rx_tail = pkt_copy->data;

			precvframe->rx_data = pkt_copy->data;

		} else {

			if ((pattrib->mfrag == 1) && (pattrib->frag_num == 0)) {

			DBG_88E("recvbuf2recvframe: alloc_skb fail , drop frag frame\n");

			rtw_free_recvframe(precvframe, pfree_recv_queue);

			goto _exit_recvbuf2recvframe;

		}

			precvframe->pkt = skb_clone(pskb, GFP_ATOMIC);

			if (precvframe->pkt) {

				precvframe->rx_tail = pbuf + pattrib->drvinfo_sz + RXDESC_SIZE;

				precvframe->rx_head = precvframe->rx_tail;

				precvframe->rx_data = precvframe->rx_tail;

				precvframe->rx_end =  pbuf + pattrib->drvinfo_sz + RXDESC_SIZE + alloc_sz;

			} else {

				DBG_88E("recvbuf2recvframe: skb_clone fail\n");

				rtw_free_recvframe(precvframe, pfree_recv_queue);

				goto _exit_recvbuf2recvframe;

			}

		}



		recvframe_put(precvframe, skb_len);