Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6456f0b7 authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Greg Kroah-Hartman
Browse files

Staging: epl: do not use CLONE_SIGHAND with allow_signal() 



Not sure this patch is really needed since kernel_thread() is deprecated
(and checkpatch.pl complains).

But we should not use kernel_thread(CLONE_SIGHAND) if we are going to play
with signals.

Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent d604fc99

drivers/staging/epl/EplSdoUdpu.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -334,7 +334,8 @@ tEplKernel EplSdoUdpuConfig(unsigned long ulIpAddr_p, unsigned int uiPort_p) 
	}

	}

	// create Listen-Thread

	// create Listen-Thread

	SdoUdpInstance_g.m_ThreadHandle =

	SdoUdpInstance_g.m_ThreadHandle =

	    kernel_thread(EplSdoUdpThread, &SdoUdpInstance_g, CLONE_KERNEL);

		kernel_thread(EplSdoUdpThread, &SdoUdpInstance_g,

				CLONE_FS | CLONE_FILES);

	if (SdoUdpInstance_g.m_ThreadHandle == 0) {

	if (SdoUdpInstance_g.m_ThreadHandle == 0) {

		Ret = kEplSdoUdpThreadError;

		Ret = kEplSdoUdpThreadError;

		goto Exit;

		goto Exit;

drivers/staging/epl/ShbIpc-LinuxKernel.c

+4 −4
Original line number Original line Diff line number Diff line
@@ -533,7 +533,7 @@ tShbError ShbIpcStartSignalingNewData(tShbInstance pShbInstance_p, 
	//create thread for signalling new data

	//create thread for signalling new data

	pShbMemInst->m_tThreadNewDataId =

	pShbMemInst->m_tThreadNewDataId =

		kernel_thread(ShbIpcThreadSignalNewData, pShbInstance_p,

		kernel_thread(ShbIpcThreadSignalNewData, pShbInstance_p,

			  CLONE_KERNEL);

				CLONE_FS | CLONE_FILES);





      Exit:

      Exit:

	return ShbError;

	return ShbError;
@@ -637,7 +637,7 @@ tShbError ShbIpcStartSignalingJobReady(tShbInstance pShbInstance_p, 
	//create thread for signalling new data

	//create thread for signalling new data

	pShbMemInst->m_tThreadJobReadyId =

	pShbMemInst->m_tThreadJobReadyId =

		kernel_thread(ShbIpcThreadSignalJobReady, pShbInstance_p,

		kernel_thread(ShbIpcThreadSignalJobReady, pShbInstance_p,

			  CLONE_KERNEL);

				CLONE_FS | CLONE_FILES);

      Exit:

      Exit:

	return ShbError;

	return ShbError;

}

}