Commit 63dd147e authored Jul 23, 2019 by Jozsef Kadlecsik Committed by Greg Kroah-Hartman Aug 29, 2019

netfilter: ipset: Fix rename concurrency with listing



[ Upstream commit 6c1f7e2c1b96ab9b09ac97c4df2bd9dc327206f6 ]

Shijie Luo reported that when stress-testing ipset with multiple concurrent
create, rename, flush, list, destroy commands, it can result

ipset <version>: Broken LIST kernel message: missing DATA part!

error messages and broken list results. The problem was the rename operation
was not properly handled with respect of listing. The patch fixes the issue.

Reported-by: Shijie Luo <luoshijie1@huawei.com>
Signed-off-by: Jozsef Kadlecsik <kadlec@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent ea08214d

net/netfilter/ipset/ip_set_core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1157,7 +1157,7 @@ static int ip_set_rename(struct net net, struct sock ctnl,
		return -ENOENT;

		write_lock_bh(&ip_set_ref_lock);
		if (set->ref != 0) {
		if (set->ref != 0 \|\| set->ref_netlink != 0) {
		ret = -IPSET_ERR_REFERENCED;
		goto out;
		}