Commit 63215705 authored Oct 29, 2016 by Julia Lawall Committed by David S. Miller Oct 31, 2016

ptp: use permission-specific DEVICE_ATTR variants

Use DEVICE_ATTR_RO for read only attributes.  This simplifies the
source code, improves readbility, and reduces the chance of
inconsistencies.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@ro@
declarer name DEVICE_ATTR;
identifier x,x_show;
@@

DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);

@script:ocaml@
x << ro.x;
x_show << ro.x_show;
@@

if not (x^"_show" = x_show) then Coccilib.include_match false

@@
declarer name DEVICE_ATTR_RO;
identifier ro.x,ro.x_show;
@@

- DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
+ DEVICE_ATTR_RO(x);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0f98621b

drivers/ptp/ptp_sysfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -28,7 +28,7 @@ static ssize_t clock_name_show(struct device *dev,
		struct ptp_clock *ptp = dev_get_drvdata(dev);
		return snprintf(page, PAGE_SIZE-1, "%s\n", ptp->info->name);
		}
		static DEVICE_ATTR(clock_name, 0444, clock_name_show, NULL);
		static DEVICE_ATTR_RO(clock_name);

		#define PTP_SHOW_INT(name, var) \
		static ssize_t var##_show(struct device *dev, \