Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 631b0cfd authored Feb 04, 2013 by Yuanhan Liu Committed by Linus Torvalds Feb 05, 2013

mm: fix wrong comments about anon_vma lock



We use rwsem since commit 5a505085 ("mm/rmap: Convert the struct
anon_vma::mutex to an rwsem").  And most of comments are converted to
the new rwsem lock; while just 2 more missed from:

	 $ git grep 'anon_vma->mutex'

Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Cc: Mel Gorman <mel@csn.ul.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 249d9d9d

include/linux/mmu_notifier.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -151,7 +151,7 @@ struct mmu_notifier_ops {
		* Therefore notifier chains can only be traversed when either
		*
		* 1. mmap_sem is held.
		* 2. One of the reverse map locks is held (i_mmap_mutex or anon_vma->mutex).
		* 2. One of the reverse map locks is held (i_mmap_mutex or anon_vma->rwsem).
		* 3. No other concurrent thread can access the list (release)
		*/
		struct mmu_notifier {

mm/mmap.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2943,7 +2943,7 @@ static void vm_lock_mapping(struct mm_struct mm, struct address_space mapping)
		* vma in this mm is backed by the same anon_vma or address_space.
		*
		* We can take all the locks in random order because the VM code
		* taking i_mmap_mutex or anon_vma->mutex outside the mmap_sem never
		* taking i_mmap_mutex or anon_vma->rwsem outside the mmap_sem never
		* takes more than one of them in a row. Secondly we're protected
		* against a concurrent mm_take_all_locks() by the mm_all_locks_mutex.
		*