Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62fd0d30 authored by Andi Shyti's avatar Andi Shyti Committed by Mauro Carvalho Chehab
Browse files

[media] cx24117: remove dead code in always 'false' if statement 



At this point of the execution in the function cx24117_attach()
demod cannot be '0'. In that case the function returns earlier
with an error value ('NULL'). Remove the if statement.

This error has been reported by scan.coverity.com

Signed-off-by: default avatarAndi Shyti <andi@etezian.org>
Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent 08e10972

drivers/media/dvb-frontends/cx24117.c

+0 −8
Original line number Diff line number Diff line
@@ -1200,12 +1200,6 @@ struct dvb_frontend *cx24117_attach(const struct cx24117_config *config, 
	state->demod = demod - 1;

	state->priv = priv;



	/* test i2c bus for ack */

	if (demod == 0) {

		if (cx24117_readreg(state, 0x00) < 0)

			goto error3;

	}



	dev_info(&state->priv->i2c->dev,

		"%s: Attaching frontend %d\n",

		KBUILD_MODNAME, state->demod);
@@ -1216,8 +1210,6 @@ struct dvb_frontend *cx24117_attach(const struct cx24117_config *config, 
	state->frontend.demodulator_priv = state;

	return &state->frontend;



error3:

	kfree(state);

error2:

	cx24117_release_priv(priv);

error1: