Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62d8e9e2 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Tony Lindgren
Browse files

omap3: igepv2: Don't call gpio_set_value right aftergpio_direction_output 



gpio_direction_output() has a value argument, there's no need to call
gpio_set_value() explicitly right after.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: default avatarEnric Balletbo i Serra <eballetbo@gmail.com>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent 65dd4c16

arch/arm/mach-omap2/board-igep0020.c

+8 −12
Original line number Original line Diff line number Diff line
@@ -377,24 +377,21 @@ static void __init igep2_leds_init(void) 
static inline void igep2_leds_init(void)

static inline void igep2_leds_init(void)

{

{

	if ((gpio_request(IGEP2_GPIO_LED0_RED, "gpio-led:red:d0") == 0) &&

	if ((gpio_request(IGEP2_GPIO_LED0_RED, "gpio-led:red:d0") == 0) &&

	    (gpio_direction_output(IGEP2_GPIO_LED0_RED, 1) == 0)) {

	    (gpio_direction_output(IGEP2_GPIO_LED0_RED, 0) == 0))

		gpio_export(IGEP2_GPIO_LED0_RED, 0);

		gpio_export(IGEP2_GPIO_LED0_RED, 0);

		gpio_set_value(IGEP2_GPIO_LED0_RED, 0);

	else

	} else

		pr_warning("IGEP v2: Could not obtain gpio GPIO_LED0_RED\n");

		pr_warning("IGEP v2: Could not obtain gpio GPIO_LED0_RED\n");





	if ((gpio_request(IGEP2_GPIO_LED0_GREEN, "gpio-led:green:d0") == 0) &&

	if ((gpio_request(IGEP2_GPIO_LED0_GREEN, "gpio-led:green:d0") == 0) &&

	    (gpio_direction_output(IGEP2_GPIO_LED0_GREEN, 1) == 0)) {

	    (gpio_direction_output(IGEP2_GPIO_LED0_GREEN, 0) == 0))

		gpio_export(IGEP2_GPIO_LED0_GREEN, 0);

		gpio_export(IGEP2_GPIO_LED0_GREEN, 0);

		gpio_set_value(IGEP2_GPIO_LED0_GREEN, 0);

	else

	} else

		pr_warning("IGEP v2: Could not obtain gpio GPIO_LED0_GREEN\n");

		pr_warning("IGEP v2: Could not obtain gpio GPIO_LED0_GREEN\n");





	if ((gpio_request(IGEP2_GPIO_LED1_RED, "gpio-led:red:d1") == 0) &&

	if ((gpio_request(IGEP2_GPIO_LED1_RED, "gpio-led:red:d1") == 0) &&

	    (gpio_direction_output(IGEP2_GPIO_LED1_RED, 1) == 0)) {

	    (gpio_direction_output(IGEP2_GPIO_LED1_RED, 0) == 0))

		gpio_export(IGEP2_GPIO_LED1_RED, 0);

		gpio_export(IGEP2_GPIO_LED1_RED, 0);

		gpio_set_value(IGEP2_GPIO_LED1_RED, 0);

	else

	} else

		pr_warning("IGEP v2: Could not obtain gpio GPIO_LED1_RED\n");

		pr_warning("IGEP v2: Could not obtain gpio GPIO_LED1_RED\n");





}

}
@@ -426,10 +423,9 @@ static int igep2_twl_gpio_setup(struct device *dev, 
	/* TWL4030_GPIO_MAX + 1 == ledB (out, active low LED) */

	/* TWL4030_GPIO_MAX + 1 == ledB (out, active low LED) */

#if !defined(CONFIG_LEDS_GPIO) && !defined(CONFIG_LEDS_GPIO_MODULE)

#if !defined(CONFIG_LEDS_GPIO) && !defined(CONFIG_LEDS_GPIO_MODULE)

	if ((gpio_request(gpio+TWL4030_GPIO_MAX+1, "gpio-led:green:d1") == 0)

	if ((gpio_request(gpio+TWL4030_GPIO_MAX+1, "gpio-led:green:d1") == 0)

	    && (gpio_direction_output(gpio + TWL4030_GPIO_MAX + 1, 1) == 0)) {

	    && (gpio_direction_output(gpio + TWL4030_GPIO_MAX + 1, 0) == 0))

		gpio_export(gpio + TWL4030_GPIO_MAX + 1, 0);

		gpio_export(gpio + TWL4030_GPIO_MAX + 1, 0);

		gpio_set_value(gpio + TWL4030_GPIO_MAX + 1, 0);

	else

	} else

		pr_warning("IGEP v2: Could not obtain gpio GPIO_LED1_GREEN\n");

		pr_warning("IGEP v2: Could not obtain gpio GPIO_LED1_GREEN\n");

#else

#else

	igep2_gpio_leds[3].gpio = gpio + TWL4030_GPIO_MAX + 1;

	igep2_gpio_leds[3].gpio = gpio + TWL4030_GPIO_MAX + 1;