Commit 62c50543 authored Apr 21, 2012 by Dan Carpenter Committed by John W. Linville May 08, 2012

wireless: at76c50x: allocating too much data



This is a cut and paste mistake, sizeof(struct mib_local) was intended
instead of sizeof(struct mib_phy).  The call to at76_get_mib() uses
sizeof(struct mib_local) correctly, although I changed that to
sizeof(*m) for style reasons after discussion with some of the wireless
maintainers.

The current code works fine because mib_phy structs are larger than
mib_local structs.  But we may as well clean it up.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 8b5bed90

drivers/net/wireless/at76c50x-usb.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1122,12 +1122,12 @@ static void at76_dump_mib_phy(struct at76_priv *priv)
		static void at76_dump_mib_local(struct at76_priv *priv)
		{
		int ret;
		struct mib_local *m = kmalloc(sizeof(struct mib_phy), GFP_KERNEL);
		struct mib_local m = kmalloc(sizeof(m), GFP_KERNEL);

		if (!m)
		return;

		ret = at76_get_mib(priv->udev, MIB_LOCAL, m, sizeof(struct mib_local));
		ret = at76_get_mib(priv->udev, MIB_LOCAL, m, sizeof(*m));
		if (ret < 0) {
		wiphy_err(priv->hw->wiphy,
		"at76_get_mib (LOCAL) failed: %d\n", ret);