Commit 6224abda authored Nov 13, 2017 by Rasmus Villemoes Committed by David S. Miller Nov 14, 2017

net: core: drop pointless check in __dev_alloc_name

The only caller passes a stack buffer as buf, so it won't equal the
passed-in name. Moreover, we're already using buf as a scratch buffer
inside the if (p) {} block, so if buf and name were the same, that
snprintf() call would be overwriting its own format string.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c46d7642

net/core/dev.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1095,7 +1095,6 @@ static int __dev_alloc_name(struct net net, const char name, char *buf)
		free_page((unsigned long) inuse);
		}

		if (buf != name)
		snprintf(buf, IFNAMSIZ, name, i);
		if (!__dev_get_by_name(net, buf))
		return i;