Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 61321d92 authored by Ben Hutchings's avatar Ben Hutchings
Browse files

sfc: Update comments on efx_rx_packet_gro() 



The in-tree driver has never supported Driverlink.  The rest of the
comments are rather redundant, but we can usefully state what the
requirements are on the buffer state.

Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
parent bdca71ed

drivers/net/ethernet/sfc/rx.c

+2 −5
Original line number Original line Diff line number Diff line
@@ -449,10 +449,8 @@ static void efx_rx_packet__check_len(struct efx_rx_queue *rx_queue, 
	efx_rx_queue_channel(rx_queue)->n_rx_overlength++;

	efx_rx_queue_channel(rx_queue)->n_rx_overlength++;

}

}





/* Pass a received packet up through the generic GRO stack

/* Pass a received packet up through GRO.  GRO can handle pages

 *

 * regardless of checksum state and skbs with a good checksum.

 * Handles driverlink veto, and passes the fragment up via

 * the appropriate GRO method

 */

 */

static void efx_rx_packet_gro(struct efx_channel *channel,

static void efx_rx_packet_gro(struct efx_channel *channel,

			      struct efx_rx_buffer *rx_buf,

			      struct efx_rx_buffer *rx_buf,
@@ -461,7 +459,6 @@ static void efx_rx_packet_gro(struct efx_channel *channel, 
	struct napi_struct *napi = &channel->napi_str;

	struct napi_struct *napi = &channel->napi_str;

	gro_result_t gro_result;

	gro_result_t gro_result;





	/* Pass the skb/page into the GRO engine */

	if (rx_buf->flags & EFX_RX_BUF_PAGE) {

	if (rx_buf->flags & EFX_RX_BUF_PAGE) {

		struct efx_nic *efx = channel->efx;

		struct efx_nic *efx = channel->efx;

		struct page *page = rx_buf->u.page;

		struct page *page = rx_buf->u.page;