Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 61110fba authored by Behan Webster's avatar Behan Webster Committed by Mauro Carvalho Chehab
Browse files

[media] ti-fpe: LLVMLinux: Remove nested function from ti-vpe 



Replace the use of nested functions where a normal function will suffice.

Nested functions are not liked by upstream kernel developers in general. Their
use breaks the use of clang as a compiler, and doesn't make the code any
better.

This code now works for both gcc and clang.

Suggested-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarBehan Webster <behanw@converseincode.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 678fa12f

drivers/media/platform/ti-vpe/csc.c

+2 −6
Original line number Diff line number Diff line
@@ -93,12 +93,8 @@ void csc_dump_regs(struct csc_data *csc) 
{

	struct device *dev = &csc->pdev->dev;



	u32 read_reg(struct csc_data *csc, int offset)

	{

		return ioread32(csc->base + offset);

	}



#define DUMPREG(r) dev_dbg(dev, "%-35s %08x\n", #r, read_reg(csc, CSC_##r))

#define DUMPREG(r) dev_dbg(dev, "%-35s %08x\n", #r, \

	ioread32(csc->base + CSC_##r))



	DUMPREG(CSC00);

	DUMPREG(CSC01);

drivers/media/platform/ti-vpe/sc.c

+2 −6
Original line number Diff line number Diff line
@@ -24,12 +24,8 @@ void sc_dump_regs(struct sc_data *sc) 
{

	struct device *dev = &sc->pdev->dev;



	u32 read_reg(struct sc_data *sc, int offset)

	{

		return ioread32(sc->base + offset);

	}



#define DUMPREG(r) dev_dbg(dev, "%-35s %08x\n", #r, read_reg(sc, CFG_##r))

#define DUMPREG(r) dev_dbg(dev, "%-35s %08x\n", #r, \

	ioread32(sc->base + CFG_##r))



	DUMPREG(SC0);

	DUMPREG(SC1);