Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60e203ec authored by Bartlomiej Zolnierkiewicz's avatar Bartlomiej Zolnierkiewicz Committed by Eduardo Valentin
Browse files

thermal: samsung: Exynos5260 and Exynos5420 should not use TRIM_RELOAD flag 



Currently these SoCs claim TRIM_RELOAD support but don't have
triminfo_ctrl register address defined in their struct
exynos_tmu_registers entries.  This causes incorrect write of
value "1" to data->base + 0x00 address (which happens to be
TRIMINFO register).  Additionally according to the documentation
that I have neither Exynos5260 nor Exynos5420 support/require
TRIM_RELOAD feature.  Thus fix the aforementioned issue by
removing TMU_SUPPORT_TRIM_RELOAD flag for both Exynos5260 and
Exynos5420.

Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: Amit Daniel Kachhap <amit.daniel@samsung.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
Acked-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: default avatarEduardo Valentin <edubezval@gmail.com>
parent 99d67fb9

drivers/thermal/samsung/exynos_tmu_data.c

+7 −9
Original line number Diff line number Diff line
@@ -331,9 +331,8 @@ static const struct exynos_tmu_registers exynos5260_tmu_registers = { 
#define EXYNOS5260_TMU_DATA \

	__EXYNOS5260_TMU_DATA \

	.type = SOC_ARCH_EXYNOS5260, \

	.features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_TRIM_RELOAD | \

			TMU_SUPPORT_FALLING_TRIP | TMU_SUPPORT_READY_STATUS | \

			TMU_SUPPORT_EMUL_TIME)

	.features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_FALLING_TRIP | \

			TMU_SUPPORT_READY_STATUS | TMU_SUPPORT_EMUL_TIME)



struct exynos_tmu_init_data const exynos5260_default_tmu_data = {

	.tmu_data = {
@@ -416,16 +415,15 @@ static const struct exynos_tmu_registers exynos5420_tmu_registers = { 
#define EXYNOS5420_TMU_DATA \

	__EXYNOS5420_TMU_DATA \

	.type = SOC_ARCH_EXYNOS5250, \

	.features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_TRIM_RELOAD | \

			TMU_SUPPORT_FALLING_TRIP | TMU_SUPPORT_READY_STATUS | \

			TMU_SUPPORT_EMUL_TIME)

	.features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_FALLING_TRIP | \

			TMU_SUPPORT_READY_STATUS | TMU_SUPPORT_EMUL_TIME)



#define EXYNOS5420_TMU_DATA_SHARED \

	__EXYNOS5420_TMU_DATA \

	.type = SOC_ARCH_EXYNOS5420_TRIMINFO, \

	.features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_TRIM_RELOAD | \

			TMU_SUPPORT_FALLING_TRIP | TMU_SUPPORT_READY_STATUS | \

			TMU_SUPPORT_EMUL_TIME | TMU_SUPPORT_ADDRESS_MULTIPLE)

	.features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_FALLING_TRIP | \

			TMU_SUPPORT_READY_STATUS | TMU_SUPPORT_EMUL_TIME | \

			TMU_SUPPORT_ADDRESS_MULTIPLE)



struct exynos_tmu_init_data const exynos5420_default_tmu_data = {

	.tmu_data = {