Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60d6e6f0 authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller
Browse files

net: bgmac: Fix endian access in bgmac_dma_tx_ring_free() 



bgmac_dma_tx_ring_free() assigns the ctl1 word which is a litle endian
32-bit word without using proper accessors, fix this, and because a
length cannot be negative, use unsigned int while at it.

Fixes: 9cde9450 ("bgmac: implement scatter/gather support")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 16a1c064

drivers/net/ethernet/broadcom/bgmac.c

+2 −1
Original line number Diff line number Diff line
@@ -533,7 +533,8 @@ static void bgmac_dma_tx_ring_free(struct bgmac *bgmac, 
	int i;



	for (i = 0; i < BGMAC_TX_RING_SLOTS; i++) {

		int len = dma_desc[i].ctl1 & BGMAC_DESC_CTL1_LEN;

		u32 ctl1 = le32_to_cpu(dma_desc[i].ctl1);

		unsigned int len = ctl1 & BGMAC_DESC_CTL1_LEN;



		slot = &ring->slots[i];

		dev_kfree_skb(slot->skb);