Commit 60c4081e authored Jul 19, 2017 by Antoine Tenart Committed by Herbert Xu Aug 03, 2017

crypto: inside-secure - fix the sha state length in hmac_sha1_setkey

A check is performed on the ipad/opad in the safexcel_hmac_sha1_setkey
function, but the index used by the loop doing it is wrong. It is
currently the size of the state array while it should be the size of a
sha1 state. This patch fixes it.

Fixes: 1b44c5a6 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 42ef3bed

drivers/crypto/inside-secure/safexcel_hash.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -883,7 +883,7 @@ static int safexcel_hmac_sha1_setkey(struct crypto_ahash tfm, const u8 key,
		if (ret)
		return ret;

		for (i = 0; i < ARRAY_SIZE(istate.state); i++) {
		for (i = 0; i < SHA1_DIGEST_SIZE / sizeof(u32); i++) {
		if (ctx->ipad[i] != le32_to_cpu(istate.state[i]) \|\|
		ctx->opad[i] != le32_to_cpu(ostate.state[i])) {
		ctx->base.needs_inv = true;