Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 609d3bbf authored by Julia Lawall's avatar Julia Lawall Committed by Paul Mundt
Browse files

drivers/video/imxfb.c: add missing clk_put

Reorder the labels at the end of the function to correspond to the order in
which the resources are allocated.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@r exists@
expression e1,e2;
statement S;
@@

e1 = clk_get@p1(...);
... when != e1 = e2
    when != clk_put(e1)
    when any
if (...) { ... when != clk_put(e1)
               when != if (...) { ... clk_put(e1) ... }
* return@p3 ...;
 } else S
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Acked-by: default avatarSascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
parent 70f289db
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -856,10 +856,10 @@ static int __init imxfb_probe(struct platform_device *pdev)
		dma_free_writecombine(&pdev->dev,fbi->map_size,fbi->map_cpu,
			fbi->map_dma);
failed_map:
	clk_put(fbi->clk);
failed_getclock:
	iounmap(fbi->regs);
failed_ioremap:
	clk_put(fbi->clk);
failed_getclock:
	release_mem_region(res->start, resource_size(res));
failed_req:
	kfree(info->pseudo_palette);